etianen / django-watson

Full-text multi-table search application for Django. Easy to install and use, with good performance.
BSD 3-Clause "New" or "Revised" License
1.2k stars 129 forks source link

`url` -> `re_path` #294

Closed Shybert closed 2 years ago

Shybert commented 2 years ago

Required for Django 4 compatibility. Seems to be the only required change

etianen commented 2 years ago

Thanks for this!

It looks like some of the builds are failing. Maybe you could take a look?

Shybert commented 2 years ago

I'll try to figure it out 👍

Shybert commented 2 years ago

Seems like the problem was that Django 4 drops compatibility for Python 3.6 and Python 3.7

etianen commented 2 years ago

Ah, I think you need to quote 3.10 as a string. The tests seem to be interpretting it as 3.1. :(

Sorry for the lack of response on this. I've started a new job and have been extremely busy!

Shybert commented 2 years ago

Everything should hopefully work now. And no worries, I fully understand a busy schedule!

etianen commented 2 years ago

Merged! Many thanks.