search

etianen / html5media

Enables <video> and <audio> tags in all major browsers.
http://html5media.info/
GNU General Public License v3.0
1.28k stars 384 forks source link

Fallback Element New Styles and New Express Install URL #40

Closed fanfavorite closed 11 years ago

fanfavorite commented 11 years ago

When the fallback element is created, it doesn't copy over styles. This change copies over the inline styles of the element. I also updated the express install url for flowplayer.

fanfavorite commented 11 years ago

An alternative to putting the new flowplayer express install path would be to just have the express install with the other flowplayer files.

etianen commented 11 years ago

It looks like you've edited the minified JavaScript directly. You'll need to edit the actual unminified source file. I can then compile this info a new version and release it on the CDN.

Regarding the express install, are you saying that the version of flowplayer being used references an external express install swf that has been taken down? How incredibly annoying. In this case, I would definitely opt for hosting the express install alongside the flowplayer swf files, to ensure that this can't happen again on future.

Thanks for your time so far on this. If you can fix up the pull request, I'll incorporate it and roll out a new release as soon as I get back from holiday (this Sunday). On 16 Sep 2013 20:40, "fanfavorite" notifications@github.com wrote:

When the fallback element is created, it doesn't copy over styles. This change copies over the inline styles of the element. I also updated the

express install url for flowplayer.

You can merge this Pull Request by running

git pull https://github.com/fanfavorite/html5media patch-1

Or view, comment on, or merge it at:

https://github.com/etianen/html5media/pull/40 Commit Summary

  • Fallback Element New Styles and New Express Install URL

File Changes

  • M cdn/www/1.1.5/html5media.min.jshttps://github.com/etianen/html5media/pull/40/files#diff-0(4)

Patch Links:

fanfavorite commented 11 years ago

You talking about at src/api/html5media.js? This is different coding. Does it get pulled it and compiled differently?

Regarding the express install, yes that external script has been taken down.

etianen commented 11 years ago

That's the one. That script gets compiled and minified as part of the build process. On 17 Sep 2013 21:21, "fanfavorite" notifications@github.com wrote:

You talking about at src/api/html5media.js? This is different coding. Does it get pulled it and compiled differently?

Regarding the express install, yes that external script has been taken down.

— Reply to this email directly or view it on GitHubhttps://github.com/etianen/html5media/pull/40#issuecomment-24619027 .