search

etianen / html5media

Enables <video> and <audio> tags in all major browsers.
http://html5media.info/
GNU General Public License v3.0
1.28k stars 384 forks source link

Fix Styles If Already Assigned #67

Closed fanfavorite closed 8 years ago

fanfavorite commented 8 years ago

The fallback element will always be set as a block element as it currently is. I needed the ability to set it as hidden on load, so I set the script to only set to block if it doesn't exist. The audio height also was set to always be 26px high. People may want to set this also, so I put through the getDimension function.

fanfavorite commented 8 years ago

In theory, makes sense, but I am not sure if there will be any issues with that. cssText has all the inline styles and seems to work reliably across browsers, so don't think we need more than that. The getDimensions seems to work fine after, so I think its just the block we need to worry about overriding like I have.

etianen commented 8 years ago

Oh, yes, I see that you're right!

etianen commented 8 years ago

Any more updates you're planning on, or shall I push a release?

fanfavorite commented 8 years ago

You can push a release. Nothing planned at this point. Thanks!

etianen commented 8 years ago

1.2.2 is now out. Thanks for your help on the project!