etienne-martin / device-detector-js

A precise user agent parser and device detector written in TypeScript
https://lx3rzx16x9.codesandbox.io/
GNU Lesser General Public License v3.0
459 stars 56 forks source link

Facebook messenger detected as Facebook #137

Open usb248 opened 2 years ago

usb248 commented 2 years ago

⚠️ Missing/incorrect detections should be reported at https://github.com/matomo-org/device-detector/issues instead of this repo.

Or not ?

https://github.com/matomo-org/device-detector/issues/6896

Tested with demo link : https://lx3rzx16x9.codesandbox.io/

etienne-martin commented 2 years ago

This should be fixed by upgrading this package to the latest version of Matomo (https://github.com/etienne-martin/device-detector-js/issues/134).

User-agent:

Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_3 like Mac OS X) AppleWebKit/603.3.8 (KHTML, like Gecko) Mobile/14G60 LightSpeed [FBAN/MessengerLiteForiOS;FBAV/334.2.0.46.118;FBBV/324707651;FBDV/iPhone5,4;FBMD/iPhone;FBSN/iOS;FBSV/10.3.3;FBSS/2;FBCR/;FBID/phone;F

Wrong result (demo):

Should be detected as Facebook Messenger Lite but gets detected as Facebook.

{
  "client":{
    "type":"mobile app"
    "name":"Facebook"
    "version":"334.2"
  }
  "os":{
    "name":"iOS"
    "version":"10.3"
    "platform":""
  }
  "device":{
    "type":"smartphone"
    "brand":"Apple"
    "model":"iPhone 5C"
  }
  "bot":NULL
}

Expected result (matomo demo):

{
  "isBot": false,
  "clientInfo": {
    "type": "mobile app",
    "name": "Facebook Messenger Lite",
    "version": "334.2.0.46.118"
  },
  "browserFamily": null,
  "isMobileOnlyBrowser": false,
  "osInfo": {
    "name": "iOS",
    "short_name": "IOS",
    "version": "10.3.3",
    "platform": "",
    "family": "iOS"
  },
  "osFamily": "iOS",
  "device": 1,
  "deviceName": "smartphone",
  "deviceBrand": {
    "name": "Apple",
    "short_name": "AP"
  },
  "model": "iPhone 5C",
  "icons": {
    "browser": null,
    "os": "/icons/os/IOS.png",
    "device": "/icons/devices/smartphone.png",
    "brand": "/icons/brand/Apple.png"
  }
}