search

etienne-martin / device-detector-js

A precise user agent parser and device detector written in TypeScript
https://lx3rzx16x9.codesandbox.io/
GNU Lesser General Public License v3.0
475 stars 58 forks source link

Windows 11 detected as Windows 10 #140

Open JainMayank99 opened 2 years ago

JainMayank99 commented 2 years ago

Tested on : https://lx3rzx16x9.codesandbox.io/

Findus23 commented 2 years ago

This seems to be intentional by Microsoft that Windows 11 sends the same user agent as Windows 10: https://stackoverflow.com/a/69650125/4398037 https://docs.microsoft.com/en-us/microsoft-edge/web-platform/how-to-detect-win11

etienne-martin commented 2 years ago

Microsoft seems to be pushing for "User-Agent Client Hints" as a less fingerprintable way to expose device information. Client hints are additional headers that are sent along with the user-agent but unfortunately this library is not equipped to deal with these new headers.

And since this library depends on Matomo device-detector for it's database of regexes, we would need to wait for them to add support for client hints (assuming that's something they want to tackle).

etienne-martin commented 2 years ago

Support for client hints was added to Matomo version 6

coreymaroney commented 2 years ago

@etienne-martin I see PR #146 open for updating to version 6. Is there a way I can assist you with getting that over the finish line?

rdvo commented 1 year ago

+1 here on that @etienne-martin