search

etiennebacher / altdoc

Alternative to pkgdown to document R packages
https://altdoc.etiennebacher.com
Other
65 stars 9 forks source link

Implement snapshot tests #222

Closed etiennebacher closed 9 months ago

etiennebacher commented 9 months ago

Close #221

This should prevent basic errors.

Quarto files change depending on the version of quarto and we always get the latest one in CI, so I removed those snapshots for now. Also quarto files are quite big, at least 500 lines, even for very basic md source

etiennebacher commented 9 months ago

I had to disable the snapshots on Windows (only on CI so that I can still use them locally) because loading the library in the man pages generated an error (but only on windows??)

@vincentarelbundock do you want to try that locally see if that works fine for you?

vincentarelbundock commented 9 months ago

I'm on windows machine, but I have none of the dev tools installed and don't know how any of it works on this machine. (I'm always working in a Linux WSL). Is a windows test what you need, or do you just want me to run on any machine locally?

etiennebacher commented 9 months ago

It should work on any OS locally, just on ci there's this windows problem. Then as long as you have testthat installed it should run fine

vincentarelbundock commented 9 months ago

Cool. I don't get any error when I run devtools::test() in the snapshot branch on my local computer.

etiennebacher commented 9 months ago

Great, thanks for testing!