etiennebacher / altdoc

Alternative to pkgdown to document R packages
https://altdoc.etiennebacher.com
Other
62 stars 9 forks source link

plot2 -> tinyplot #258

Closed eddelbuettel closed 6 months ago

eddelbuettel commented 6 months ago

@grantmcdermott renamed the package from plot2 to tinyplot but didn't put stubs for plot2 on his website so the links are currently borked. I'd edit it in place but because you have two READMEs it may be better if I leave it to you.

etiennebacher commented 6 months ago

Thanks, should be fixed in da02933

eddelbuettel commented 6 months ago

This man is faster than the speed of light :)

grantmcdermott commented 6 months ago

didn't put stubs for plot2

Wait, what should I have done?

grantmcdermott commented 6 months ago

Also, still seems to be wrong on the actual altdoc website. (Am I just late to the part and missing something?)

eddelbuettel commented 6 months ago

The URL https://grantmcdermott.com/plot2 was once valid and promoted as the package existed for a few months and nobody was too shy about it. You could have (and I stress 'could', I am not being normative here) added a webserver redirect or (and my personal fave on local sites) a softlink. But you didn't. So when I followed along the docs from @vincentarelbundock 's toot earlier I hit the dreaded 404. Oh well.

Issue filed, and Etienne, faster than superman himself, fixed it already. Now I guess it is a matter of rolling that fix to where it needs to be and/or you bribing your kids by giving them a cookie for every plot2 URL they find in the wild. And two for correcting those.

Didn't someone say naming was hard? Try renaming...

etiennebacher commented 6 months ago

Also, still seems to be wrong on the actual altdoc website

Indeed, that should be fixed now but I had to patch it manually because the README.md file was not pushed automatically to gh-pages branch. I'll open a new issue for that, nice catch

grantmcdermott commented 6 months ago

Ah, good callout. I'll add a redirect softlink when I get a sec. Also need to do this for another renamed package. 😬

eddelbuettel commented 6 months ago

We are fighting the good fight of combatting link rot, one ln -s at a time!