Equivalence with `lintr`

[etiennebacher]

https://lintr.r-lib.org/dev/reference/#individual-linters

• [ ] absolute_path_linter - Hard, see #42
  • [x] any_duplicated_linter
  • [x] any_is_na_linter
  • [x] assignment_linter
  • [ ] backport_linter
  • [ ] boolean_arithmetic_linter
  • ~brace_linter~
  • [x] class_equals_linter
  • [ ] commas_linter
  • ~commented_code_linter~ - Not possible since this only appears as kind "comment" in tree-sitter. Potentially: https://github.com/r-lib/tree-sitter-r/issues/68
  • [x] condition_message_linter
  • [ ] conjunct_test_linter
  • [ ] consecutive_assertion_linter
  • [ ] cyclocomp_linter
  • [x] duplicate_argument_linter
  • [x] empty_assignment_linter
  • [x] equals_na_linter
  • [x] expect_comparison_linter
  • [x] expect_identical_linter
  • [x] expect_length_linter
  • [x] expect_named_linter
  • [x] expect_not_linter
  • [x] expect_null_linter
  • [ ] expect_s3_class_linter
  • [ ] expect_s4_class_linter
  • [x] expect_true_false_linter
  • [x] expect_type_linter
  • ~extraction_operator_linter~ - deprecated
  • [ ] fixed_regex_linter
  • [x] for_loop_index_linter
  • [ ] function_argument_linter
  • [ ] ~function_left_parentheses_linter~
  • [x] function_return_linter
  • [ ] if_not_else_linter
  • ~ifelse_censor_linter~ Won't implement, I think it makes the code less readable
  • [x] implicit_assignment_linter
  • ~implicit_integer_linter~ Won't implement, I think this is rarely useful and makes the code less readable
  • ~indentation_linter~
  • ~infix_spaces_linter~
  • [ ] inner_combine_linter
  • [x] is_numeric_linter
  • [ ] keyword_quote_linter
  • [x] length_levels_linter
  • [x] length_test_linter
  • [x] lengths_linter
  • [x] library_call_linter
  • ~line_length_linter~
  • [x] literal_coercion_linter
  • [x] matrix_apply_linter
  • [x] missing_argument_linter
  • [ ] missing_package_linter
  • [ ] namespace_linter
  • [x] nested_ifelse_linter
  • [ ] nonportable_path_linter
  • [x] numeric_leading_zero_linter
  • [ ] object_length_linter
  • [ ] object_name_linter
  • [ ] object_usage_linter
  • [x] outer_negation_linter
  • [x] package_hooks_linter
  • ~paren_body_linter~
  • [x] paste_linter
  • [ ] pipe_call_linter
  • [ ] pipe_consistency_linter
  • ~pipe_continuation_linter~
  • [ ] quotes_linter
  • [x] redundant_equals_linter
  • [x] redundant_ifelse_linter
  • [ ] regex_subset_linter
  • [x] rep_len_linter
  • [ ] repeat_linter
  • [ ] routine_registration_linter
  • [x] sample_int_linter
  • [ ] scalar_in_linter
  • [x] semicolon_linter
  • [x] seq_linter
  • [x] sort_linter
  • ~spaces_inside_linter~
  • ~spaces_left_parentheses_linter~
  • [ ] sprintf_linter
  • [ ] string_boundary_linter
  • [ ] strings_as_factors_linter
  • [ ] system_file_linter
  • [x] T_and_F_symbol_linter
  • [x] todo_comment_linter
  • ~trailing_blank_lines_linter~
  • ~trailing_whitespace_linter~
  • [x] undesirable_function_linter
  • [x] undesirable_operator_linter
  • [ ] unnecessary_concatenation_linter
  • [ ] unnecessary_lambda_linter
  • [x] unnecessary_nesting_linter
  • [ ] unnecessary_placeholder_linter
  • [x] unreachable_code_linter
  • [ ] unused_import_linter
  • [ ] vector_logic_linter
  • [x] which_grepl_linter
  • ~whitespace_linter~
  • [ ] yoda_test_linter

[etiennebacher]

For unnecessary_nested_if_linter: https://ast-grep.github.io/playground.html#eyJtb2RlIjoiQ29uZmlnIiwibGFuZyI6ImphdmFzY3JpcHQiLCJxdWVyeSI6IiIsInJld3JpdGUiOiJsb2dnZXIubG9nKCRNQVRDSCkiLCJzdHJpY3RuZXNzIjoic21hcnQiLCJzZWxlY3RvciI6IiIsImNvbmZpZyI6InJ1bGU6XG4gIGtpbmQ6IGlmX3N0YXRlbWVudFxuICBoYXM6XG4gICAga2luZDogc3RhdGVtZW50X2Jsb2NrXG4gICAgaGFzOiAgXG4gICAgICBraW5kOiBpZl9zdGF0ZW1lbnRcbiAgICAgIHN0b3BCeTogbmVpZ2hib3JcbiAgICBub3Q6XG4gICAgICBoYXM6XG4gICAgICAgIG50aENoaWxkOiAyXG4iLCJzb3VyY2UiOiJpZiAoQSkge1xuICBpZiAoQikge1xuICAgIGNvbnNvbGUubG9nKCdtYXRjaGVkIGluIG1ldGF2YXIhJylcbiAgfVxufVxuXG5pZiAoQSkge1xuICBpZiAoQikge1xuICAgIGNvbnNvbGUubG9nKCdtYXRjaGVkIGluIG1ldGF2YXIhJylcbiAgfVxuICBsZXQgeCA9IDE7XG59XG5cbmlmIChBKSB7XG4gIGxldCB4ID0gMTtcbiAgaWYgKEIpIHtcbiAgICBjb25zb2xlLmxvZygnbWF0Y2hlZCBpbiBtZXRhdmFyIScpXG4gIH1cbn0ifQ==

[etiennebacher]

I think a linter shouldn't take care of whitespaces and other things that don't modify the AST but are "purely aesthetic", that's the role of a formatter (and I don't think ast-grep is the right tool for this). So I remove from the list all linters related to formatting.