etiennebacher / tidypolars

Get the power of polars with the syntax of the tidyverse
https://tidypolars.etiennebacher.com
Other
141 stars 3 forks source link

Delete `as_polars` in favor of `polars::as_polars_df` and `polars::as_polars_lf` #76

Closed eitsupi closed 5 months ago

eitsupi commented 6 months ago

Some related thoughts:

etiennebacher commented 6 months ago

Thanks for the comments, I should indeed deprecate as_polars() since I reexport polars::as_polars_*() functions (those weren't there when I implemented as_polars())

polars::pl$enable_string_cache() should be able to run when the package is loaded.

Isn't it already the case? Do you have an error when you run this?

eitsupi commented 5 months ago

Isn't it already the case? Do you have an error when you run this?

Oh, sorry. I just read the code below and thought that might be necessary, but I don't actually understand what these things do. https://github.com/etiennebacher/tidypolars/blob/1838b583d0fa4c157d3ad3b6a99abf18d7c3bf8d/R/as_polars.R#L21-L27

etiennebacher commented 5 months ago

I removed it in #79, not a good idea to modify the global state via an argument

etiennebacher commented 5 months ago

I'm not super convinced about overwriting the print method, and it should be a separate issue so I'm closing this