search

etiennedub / pyk4a

Python 3 wrapper for Azure-Kinect-Sensor-SDK
MIT License
287 stars 81 forks source link

Adding a context manager for playback objects #130

Closed qenops closed 3 years ago

qenops commented 3 years ago

With statements keep things tidy. So I added support for them in the playback object.

codecov[bot] commented 3 years ago

Codecov Report

Merging #130 (7dea312) into develop (54d90ec) will decrease coverage by 0.32%. The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #130      +/-   ##
===========================================
- Coverage    86.47%   86.15%   -0.33%     
===========================================
  Files           10       10              
  Lines          710      715       +5     
===========================================
+ Hits           614      616       +2     
- Misses          96       99       +3
Impacted Files Coverage Δ
pyk4a/playback.py 95.72% <40.00%> (-2.49%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54d90ec...7dea312. Read the comment docs.

lpasselin commented 3 years ago

Hi and thank you for the PR! We'll merge this in the develop branch. Is it possible for you to rebase your branch on develop before merging?

qenops commented 3 years ago

Yeah...I don't know why I didn't do my changes on develop to start with. Will update soon.

qenops commented 3 years ago

Updated my branch.