Fix multi-line log output

etiennelenhart / Eiffel

Redux-inspired Android architecture library leveraging Architecture Components and Kotlin Coroutines

MIT License

211 stars 14 forks source link

Fix multi-line log output #77

Closed jordond closed 5 years ago

jordond commented 5 years ago

One thing I didn't catch with PR #72 is the log output can be wonky because of the use of multi-line kotlin string literals.

Before: (I added a dummy interception to showcase the indent problem)

After:

So I have replaced all the multi-line strings with calls to the log function.

etiennelenhart commented 5 years ago

Ah dang it, I also didn't catch that. I took the EiffelViewModel unit test to generate some sample output using Kotlin's println() and this doesn't seem to have any problems with multi-line strings. I'll check again tomorrow but will probably just merge your changes. Guess I really have to start working on a sample app to provide a somewhat real-world testing area.

jordond commented 5 years ago

I did the same... Didn't notice until I started using it in my actual project. I do have a basic sample app branch on my fork now, for testing my PR's more.

I have also discovered another bug I didn't notice before #78, we can discuss it there then I can make a PR.