search

etingof / pyasn1-modules

ASN.1 modules for pyasn1 library
http://snmplabs.com/pyasn1/
BSD 2-Clause "Simplified" License
41 stars 45 forks source link

Add support for RFC 3125 and RFC 5126 #107

Closed russhousley closed 4 years ago

russhousley commented 4 years ago

Add modules and tests for RFC 3125 and RFC 5126.

codecov-io commented 4 years ago

Codecov Report

Merging #107 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   99.36%   99.39%   +0.03%     
==========================================
  Files          98      100       +2     
  Lines        5990     6288     +298     
==========================================
+ Hits         5952     6250     +298     
  Misses         38       38
Impacted Files Coverage Δ
pyasn1_modules/rfc5126.py 100% <100%> (ø)
pyasn1_modules/rfc3125.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 238ef5e...89beaae. Read the comment docs.

etingof commented 4 years ago

Thank you!

etingof commented 4 years ago

BTW, please, update your master - recent upstream changes do not seem to be reflected in your PR.

etingof commented 4 years ago

In particular, these CHANGELOG entries should have gone to the next upper section. I've fixed that in upstream master.