search

etingof / pysmi

SNMP MIB parser
http://snmplabs.com/pysmi/
BSD 2-Clause "Simplified" License
132 stars 51 forks source link

Switch to urllib2 #29

Closed etingof closed 6 years ago

etingof commented 6 years ago

This patch replaces httplib with urllib2 in the httpreader mainly to support HTTP/S proxy through respecting http_proxy environment variable by urllib2.

Note that ftpreader still relies on ftplib which is not proxy-aware.

codecov-io commented 6 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.15%. The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   60.56%   60.71%   +0.15%     
==========================================
  Files          30       30              
  Lines        2924     2920       -4     
==========================================
+ Hits         1771     1773       +2     
+ Misses       1153     1147       -6
Impacted Files Coverage Δ
pysmi/reader/httpclient.py 40.42% <23.52%> (+7.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d3e228...22006bf. Read the comment docs.