RJP43
commented
7 years ago @etj27 Your current site on newtfire is humorous! Your working javaScript and SSI reflect some of the skills you have picked up in our DH course as well as throughout your CS degree. See my suggestions above to improve this site. In the future, you might consider using this web space to display your digital scholarship in a more professional manner, but for the purposes of HTML Ex. 1 and 2 this works!
@etj27 Here are some preliminary comments regarding your webpage on newtfire.org:
You had a couple of hiccups getting your permissions set so your site could be visible. Thank you for sticking around after class on Monday to sort those out. Remember as you do HTML Exercise 2 to check your permissions, move ALL files from your local Git workspace to GitHub and the PSC, and to logically name your files. If you plan on using this repo for future web development you might consider renaming the repo to reflect that and be sure to add @ebeshero and me as collaborators. Also, you will want to keep this space clear of extra files that might confuse your web development. Looks like this might be a duplicate file to remove.
Here are my suggestions to better your webpage:
For HTML Exercise 2 we would like to see you make at least one interior link to a subpage of this main page as well as some external links. You might consider revamping your initial page here to reflect a more professional personal webpage. Perhaps add a picture of yourself and discuss your accomplishments or goals. A personal webpage is a requirement for the Digital Studies Certificate if you are pursuing that.
I really like your logical use of
<div>elements and a<section>element. I noticed in your CSS you do some styling on all divs and then some more specific styling using the class declaration to style the div holding one of your images. Neither of these rules defines styling on your paragraph content. Experiment with styling your text and images for a smoother transition from images to narrative text.<section>elements are good for disability web readers and the title attributes act as indications of the sections content. Your section title as "Bo" does not make it inherently clear what the section contains. You always want your code to be clear and concise.Your CSS, at this point, is very basic, but as it becomes more complicated it might be useful to add comment tags (
/*comment in here*/) to organize the different sections of styling that go with different pages.Check CourseWeb for your grade on this assignment. @ebeshero and I look forward to seeing how you change your page for Exercise 2!