etkachev / nx-webstorm

Plugin for Webstorm that strives to function the same as Nx Console for VsCode. UI for Nx
MIT License
35 stars 4 forks source link

Update MyProjectService.kt #113

Open ofirrifo opened 1 year ago

ofirrifo commented 1 year ago

fix path for nx version 16 or above /tools/workspace-plugin/src/generators

Current Behavior

After I update to NX 16.6.0 all Generators not display any more in Webstorm

I created PR with the fix https://github.com/etkachev/nx-webstorm/pull/113 I don't know how to upgrade the version

How to Reproduce

Expected Behavior

To show all Generators options Screenshot 2023-08-03 at 15 29 32

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

The issue come from this file: https://github.com/etkachev/nx-webstorm/blob/master/src/main/kotlin/com/github/etkachev/nxwebstorm/services/MyProjectService.kt

Lines 74-75

 val defaultCustomSchematicsLocation: String
    get() = if (this.isNx11OrAbove) "/tools/generators" else "/tools/schematics"

In NX version 16 the path to generators are /tools/workspace-plugin/src/generators

etkachev commented 1 year ago

Hello! Thanks for mentioning the issue! I actually recently updated the plugin for new plugin support. You can see the changes here: https://github.com/etkachev/nx-webstorm/commit/ee56877f67037ae8da11282128f8cde8055dfb1a

etkachev commented 1 year ago

Hello! Thanks for mentioning the issue! I actually recently updated the plugin for new plugin support. You can see the changes here: ee56877

But this looks under all generators under libs. I'll just have to add support to also search under tools

ofirrifo commented 1 year ago

@etkachev First I want to say Thanks as it awesome plugin and I love using it :) Does your fix include the change of NX command ? as they are not using any more the @nx/cli .