search

etkachev / nx-webstorm

Plugin for Webstorm that strives to function the same as Nx Console for VsCode. UI for Nx
MIT License
35 stars 4 forks source link

Not passing falsy values from generator to CLI #97

Open ntucakovic opened 2 years ago

ntucakovic commented 2 years ago

Current Behavior

A clear and concise description of what the bug is.

How to Reproduce

Steps to reproduce the behavior:

  1. Click @nrwl/react library generator in the side panel
  2. Find strict flag, that defaults to true
  3. Uncheck it
  4. Dry run the command

Expected Behavior

I expect to pass down strict=false to the executed command, so it can be read from retrieved options in JS. It will be set to default true if not passed.

Desktop (please complete the following information):

Additional context

Stumbled on this issue when using custom generator that has boolean flags that default to true. Can't get a falsy value when I uncheck a box. This issue doesn't occur for NX Console in the VS Code.

etkachev commented 2 years ago

Hello! Thanks for pointing it out. I will try to look into it soon.

etkachev commented 1 year ago

I also wanted to let you know about slowly deprecating this plugin in favor for the official on by Nrwl: https://plugins.jetbrains.com/plugin/21060-nx-console