search

etke / checksec.rs

Fast multi-platform (ELF/PE/MachO) binary checksec written in Rust.
Apache License 2.0
97 stars 12 forks source link

Upgrade dependencies and move away from unmaintained crates #20

Closed marcograss closed 2 years ago

marcograss commented 2 years ago

this PR upgrades the dependencies, the only one involving some changes in the code is Clap to the next major It also replaces memmap with memmap2 since the original crate is unmaintained

I only tested on macOS so it's better to give it a try on Windows since the windows crate has been updated as well

etke commented 2 years ago

Thanks for the updates, mind rebasing your branch on current master?

marcograss commented 2 years ago

Thanks for the updates, mind rebasing your branch on current master?

done, is the CI running?

marcograss commented 2 years ago

nice catches, I fixed them in the new commit. I got confused while rebasing

etke commented 2 years ago

Appears the latest windows crate added Option around some of the used API args https://github.com/etke/checksec.rs/actions/runs/3220737878/jobs/5285290254

If you want to update to fix those you can or you can drop the windows crate update from this PR, and I'll update the crate and associated code in a subsequent commit.

marcograss commented 2 years ago

I fixed the build on windows

marcograss commented 2 years ago

I addressed the code formatting errors, however the one involving the Arg subcalls (help, long_name etc) might be a little fragile if cargo fmt behavior changes in the future, anyway for now it's ok

etke commented 2 years ago

Merged. Thanks for your contributions!