Open GoogleCodeExporter opened 8 years ago
But active? or grey meaning disabled? (IOW, is this an appearance or
functionality issue?)
Original comment by gregnea...@mac.com
on 26 Aug 2014 at 1:05
This is purely cosmetic. It functions as expected.
Original comment by gra...@grahamgilbert.com
on 26 Aug 2014 at 1:09
This might be a Yosemite bug. If I Enter full screen and then Exit full screen,
the search field has a white(ish) background now.
I see a similar set of issues with the update badge: if there are available
updates, the icon is shrunken with the badge. I Enter full screen and then Exit
full screen, and now the icon and badge are drawn at normal size.
Same with the navigation buttons on the left; sometimes they are drawn with no
background as shown in your screenshot; after a full-screen round-trip they
gain white backgrounds.
Not sure I'll spend too much time on it for now...
Original comment by gregnea...@mac.com
on 26 Aug 2014 at 4:21
Just to clarify: I might not spend a lot of time on it now, but I intend to
make sure it looks right by the time 10.10 ships.
Original comment by gregnea...@mac.com
on 26 Aug 2014 at 4:47
Graham, could you note which beta release version of Yosemite you are testing
on? One of our systems is running the beta as well (not sure if it is
currently on the latest, they have been doing updates pretty fast lately). When
testing it would be helpful to know if we are testing on the same version or a
newer version.
Original comment by danielha...@gmail.com
on 1 Sep 2014 at 6:18
This is on build 14A329f
Original comment by gra...@grahamgilbert.com
on 1 Sep 2014 at 6:20
The behaviors have changed (at least for me). Using Munki tools 2.0.0.2212 and
OS X 10.10 14A343f, the search bar and navigation buttons now appear with their
white backgrounds. If you enter full screen mode, they lose their backgrounds.
Exiting full-screen mode, their backgrounds return.
As for the item count badge on the Updates button, this behavior is unchanged:
initially the button image (and badge) are downscaled; when you enter full
screen mode they appear at the correct size; when you exit full screen mode
they remain at the correct size.
Original comment by gregnea...@mac.com
on 3 Sep 2014 at 3:54
Would love other people looking at this; I've made zero progress on the badged
icon issue in Yosemite.
Original comment by gregnea...@mac.com
on 4 Sep 2014 at 8:55
How are the release versions (ie. 2212) mapped to commits? I'm only seeing
0.8.x tags in the munki2 branch. I still had build 2091 installed, in which the
search cell works fine. Trying to do a diff.
Original comment by jor...@gmail.com
on 9 Sep 2014 at 10:32
There are no release versions of Munki 2 yet; there are just builds. If you
look at the builds at munkibuilds.org, you can find the Git revisions that
correspond.
The search cell works "fine" before the switch to a real NSToobar, which
happened here:
https://code.google.com/p/munki/source/detail?r=caeecc92e3b52c5e175fbdfd8d5138d5
c0eb6d38&name=Munki2
and was first built by MunkiBuilds here: https://munkibuilds.org/2.0.0.2172/
The switch to a real NSToolbar made for better localization and more Mac-like
behavior when in full-screen mode, but added some cosmetic issues under
Yosemite. A diff isn't really going to help here; we're probably not going to
revert to a fake toolbar.
Original comment by gregnea...@mac.com
on 9 Sep 2014 at 10:42
Only thing I've been able to find, the NSSearchField and NSSearchFieldCell both
return no/false to drawsBackground() in full screen mode, but then I checked
regular mode and it's false there as well. The backgroundColor is
NSCalibratedWhiteColorSpace, which seems correct as well.
Quick fix, disable full-screen mode on the MSC window?
Original comment by jor...@gmail.com
on 10 Sep 2014 at 3:41
Attachments:
I would not consider that a fix!
Original comment by gregnea...@mac.com
on 10 Sep 2014 at 3:42
So call it what it is: removing functionality to avoid a bug. Is full screen
necessary for an application like MSC? I understand that full-screen is a very
mavericks-y thing to implement, but how would it actually benefit a user? The
web view doesn't redraw or responsively react to use the additional screen real
estate.
Original comment by jor...@gmail.com
on 10 Sep 2014 at 4:07
Disabling full-screen mode doesn't cause the toolbar items to draw properly,
though, so we remove expected modern functionality, but it doesn't address the
issue.
Original comment by gregnea...@mac.com
on 10 Sep 2014 at 4:14
I didn't have any pending updates, now I see the size w/ badge. Doesn't seem to
matter what size the NSImage is. Cell scaling of
NSImageScaleProportionallyUpOrDown seems better, but the icon without badge is
then too large.
Any contingency plan if these are yosemite bugs not fixed by GM?
Original comment by jor...@gmail.com
on 10 Sep 2014 at 5:09
The obvious contingency plan is to say "these are cosmetic issues only; no
actual functionality is affected".
Original comment by gregnea...@mac.com
on 10 Sep 2014 at 5:12
Cosmetic issues seem reduced in latest DP (8) or 14A361c --
In non-full screen mode, navigation buttons and search fields look OK, and the
count badge on the updates icon does not cause the icon to be shrunk.
After entering full-screen mode, the navigation buttons and search field lose
their backgrounds. Badged icon still looks OK.
After exiting full-screen mode, all toolbar elements look as expected.
Original comment by gregnea...@mac.com
on 16 Sep 2014 at 12:48
I haven't had a chance to dig into this yet other than to do a pure objective-c
test program with a search field in the toolbar and it worked as expected going
into fullscreen (kept the background). So there is likely something in the way
the search field is setup/added that is making it not quite correct in the eyes
of the OS.
Original comment by danielha...@gmail.com
on 16 Sep 2014 at 5:29
The search field and navigation buttons are embedded in an NSBox in order to
better control their layout.
Original comment by gregnea...@mac.com
on 16 Sep 2014 at 11:06
Issue 389 has been merged into this issue.
Original comment by gregnea...@mac.com
on 19 Sep 2014 at 9:09
Original issue reported on code.google.com by
gra...@grahamgilbert.com
on 26 Aug 2014 at 10:56Attachments: