search

etmc / tmLQCD

tmLQCD is a freely available software suite providing a set of tools to be used in lattice QCD simulations. This is mainly a HMC implementation (including PHMC and RHMC) for Wilson, Wilson Clover and Wilson twisted mass fermions and inverter for different versions of the Dirac operator. The code is fully parallelised and ships with optimisations for various modern architectures, such as commodity PC clusters and the Blue Gene family.
http://www.itkp.uni-bonn.de/~urbach/software.html
GNU General Public License v3.0
32 stars 47 forks source link

Multiple definitions of structure Direction in little_field_gather.c and little_D.c #485

Closed sunpho84 closed 3 years ago

sunpho84 commented 3 years ago 
/usr/bin/ld: ./lib/libxchange.a(little_field_gather.o):/home/francesco/QCD/SORGENTI/tmLQCD/build_quda/xchange/../../xchange/little_field_gather.c:47: multiple definition of `Direction'; ./lib/libhmc.a(little_D.o):/home/francesco/QCD/SORGENTI/tmLQCD/build_quda/../little_D.c:71: first defined here

a Direction structure is indeed defined in both little_field_gather.c and little_D.c, but in the second is never referred, so I guess it can be removed

urbach commented 3 years ago

are you sure that this is the latest version of the DD solver? I have the feeling that I fixed these problems already at some point?

/usr/bin/ld: ./lib/libxchange.a(little_field_gather.o):/home/francesco/QCD/SORGENTI/tmLQCD/build_quda/xchange/../../xchange/little_field_gather.c:47: multiple definition of `Direction'; ./lib/libhmc.a(little_D.o):/home/francesco/QCD/SORGENTI/tmLQCD/build_quda/../little_D.c:71: first defined here

a Direction structure is indeed defined in both little_field_gather.c and little_D.c, but in the second is never referred, so I guess it can be removed

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/etmc/tmLQCD/issues/485

-- Carsten Urbach e-mail: @. @. Fon : +49 (0)228 73 2379 skype : carsten.urbach URL: http://www.carsten-urbach.eu

kostrzewa commented 3 years ago

This may very well be. https://github.com/etmc/tmLQCD/pull/460 has been waiting for a review since April 2019 and there are conflicts in various files indicated in that pull.

kostrzewa commented 3 years ago

I think we need to merge master into quda_work first and then see from there... I'm afraid the number of conflicts is really high.

kostrzewa commented 3 years ago

@urbach the multiple definitions stuff definitely is still a problem in the master branch, it's just "by accident" that the issue was not triggered by compilers prior to GCC 10 apparently...