search

etn-ccis / blui-icons

Brightlayer UI icons for Eaton applications. Includes design files, icon font, and svg icons
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

Publish mui icons v3.3.0 #242

Closed daileytj closed 1 year ago

daileytj commented 1 year ago

Changes proposed in this Pull Request:

huayunh commented 1 year ago

Fresh clone yarn start gives me these diffs. Visually they are still the same.

image
jeffvg commented 1 year ago

Fresh clone yarn start gives me these diffs. Visually they are still the same.

image

did you mean yarn sprites not start?

huayunh commented 1 year ago

I mean yarn start. If yarn sprites needs to be a step in generating these icons, please incorporate that into yarn start.

daileytj commented 1 year ago

I mean yarn start. If yarn sprites needs to be a step in generating these icons, please incorporate that into yarn start.

Is adding the sprite stuff to the script something we want to do? I'm not sure why there were changes or what the sprite "optimization" is even doing. I would have rather just left that update out entirely.

huayunh commented 1 year ago

Our general expectation is that yarn start should prepare the package as it would be distributed to adopters and run a demo to prove that everything works. If this one deviates from that goal, please modify yarn start or log an issue.

yarn sprite supposedly "optimize" SVG files, to a limited extend. In our case, I do not see a significant improvement in file size. What would be your opinion, @daileytj ?

daileytj commented 1 year ago

Our general expectation is that yarn start should prepare the package as it would be distributed to adopters and run a demo to prove that everything works. If this one deviates from that goal, please modify yarn start or log an issue.

yarn sprite supposedly "optimize" SVG files, to a limited extend. In our case, I do not see a significant improvement in file size. What would be your opinion, @daileytj ?

I'm just going to revert the "optimization" for now.