etn-ccis / blui-react-auth-shared

Shared logic package for @brightlayer-ui/react-auth-workflow and @brightlayer-ui/react-native-auth-workflow
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Added translations for confirm password error state #103

Closed surajeaton closed 1 year ago

surajeaton commented 1 year ago

Fixes # BLUI-3944

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

-

To Test:

Any specific feedback you are looking for?

huayunh commented 1 year ago

I see that we already have this: https://github.com/etn-ccis/blui-react-auth-shared/blob/e8d29ca51f882c2b41306086c2ffcfd91f58c3f1/src/data/translations/english.ts#L112

and you added this https://github.com/etn-ccis/blui-react-auth-shared/blob/e8d29ca51f882c2b41306086c2ffcfd91f58c3f1/src/data/translations/english.ts#L163

Are you able to either

(1) reuse what's already there, or if that is not possible (2) make the verbiage match?

surajeaton commented 1 year ago

I see that we already have this:

https://github.com/etn-ccis/blui-react-auth-shared/blob/e8d29ca51f882c2b41306086c2ffcfd91f58c3f1/src/data/translations/english.ts#L112

and you added this

https://github.com/etn-ccis/blui-react-auth-shared/blob/e8d29ca51f882c2b41306086c2ffcfd91f58c3f1/src/data/translations/english.ts#L163

Are you able to either

(1) reuse what's already there, or if that is not possible (2) make the verbiage match?

I will reuse the PASS_MATCH_ERROR for this. Closing this PR, as there are no changes needed in shared auth.