search

etn-ccis / blui-react-component-library

Re-usable React components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
16 stars 10 forks source link

Would like to see component color props supporting the MUIv5's sx shorthand #754

Open huayunh opened 1 year ago

huayunh commented 1 year ago

Describe the desired feature/functionality

Low priority stuff. Nice to have.

Would like to see the BLUI components allow their color-related props to take inputs such as "primary.main". This facilitates switching between light and dark theme

joebochill commented 8 months ago

As long as the colors are being applied in an sx prop, these values will be accepted. However, it looks like all of our components are currently built using classes for styling. I suspect we'd need to do a fair bit of rewriting to support this (although I think this is the right direction to go in — we can also get away from provided classes for overrides and encourage teams to use nested SX rules instead. We will just need to budget enough time for this refactor).