Closed JeffGreiner-eaton closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
53a00e8
) 84.03% compared to head (66feb8c
) 84.03%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Visit the preview URL for this PR (updated for commit 66feb8c):
https://blui-react-docs--pr850-bug-blui-5256-mobile-s6pe8xfp.web.app
(expires Wed, 14 Feb 2024 18:09:43 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65
When hovered, your drawer did a "content-cover" animation and did not shrink the page body. However, when I clicked on the hamburger menu, the drawer did a partial content push. It shrank the page body width, but not the app bar. You would want to make the behavior more consistent. This can potentially be fixed in only the drawer playground. But if you think there might be a bug for the persistent drawer component itself, please log an issue.
Here's a screen recording to help illustrate what I am talking about:
Untitled.mov
Yes I see the same on the deployed master branch dev docs as well. https://brightlayer-ui-components.github.io/react/components/drawer/playground I will create issue
Fixes https://github.com/etn-ccis/blui-react-component-library/issues/806.
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
-
To Test:
Any specific feedback you are looking for?