Closed JeffGreiner-eaton closed 5 months ago
Attention: Patch coverage is 93.33333%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 83.76%. Comparing base (
21fee0a
) to head (af5fb9c
).
Files | Patch % | Lines |
---|---|---|
components/src/core/Drawer/Drawer.tsx | 66.66% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Visit the preview URL for this PR (updated for commit af5fb9c):
https://blui-react-docs--pr856-bug-blui-5304-duplic-1bu9rcfe.web.app
(expires Fri, 01 Mar 2024 19:54:41 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65
This would be a good rule to add in the eslint configuration to avoid the errors when we destructure but don't need to use a value (like classes):
"@typescript-eslint/no-unused-vars": ["error", { "ignoreRestSiblings": true }]
Something is broken with the Nav Items, they look funky:
Suggest you take a look at this and consider enabling the react-hooks eslint plugin to help catch all of the missing dependency array entries: https://github.com/etn-ccis/blui-react-component-library/issues/860
Fixes https://github.com/etn-ccis/blui-react-component-library/issues/216. Fixes https://github.com/etn-ccis/blui-react-component-library/issues/860.
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
New![image](https://github.com/etn-ccis/blui-react-component-library/assets/119693939/21216a5c-cabf-4dbf-a83c-b25e96b05012)
Old![image](https://github.com/etn-ccis/blui-react-component-library/assets/119693939/0f598ddb-2fb4-417f-9481-98875aa02ff7)
To Test:
classes={{ value: 'MyTestClass' }}
and saveAny specific feedback you are looking for?