etn-ccis / blui-react-component-library

Re-usable React components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
16 stars 10 forks source link

remove classes from combine function #856

Closed JeffGreiner-eaton closed 5 months ago

JeffGreiner-eaton commented 6 months ago

Fixes https://github.com/etn-ccis/blui-react-component-library/issues/216. Fixes https://github.com/etn-ccis/blui-react-component-library/issues/860.

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.76%. Comparing base (21fee0a) to head (af5fb9c).

Files Patch % Lines
components/src/core/Drawer/Drawer.tsx 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #856 +/- ## ========================================== - Coverage 83.93% 83.76% -0.18% ========================================== Files 58 58 Lines 1239 1226 -13 Branches 159 154 -5 ========================================== - Hits 1040 1027 -13 Misses 100 100 Partials 99 99 ``` | [Flag](https://app.codecov.io/gh/etn-ccis/blui-react-component-library/pull/856/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/etn-ccis/blui-react-component-library/pull/856/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | `83.76% <93.33%> (-0.18%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

Visit the preview URL for this PR (updated for commit af5fb9c):

https://blui-react-docs--pr856-bug-blui-5304-duplic-1bu9rcfe.web.app

(expires Fri, 01 Mar 2024 19:54:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

joebochill commented 6 months ago

This would be a good rule to add in the eslint configuration to avoid the errors when we destructure but don't need to use a value (like classes):

 "@typescript-eslint/no-unused-vars": ["error", { "ignoreRestSiblings": true }]
joebochill commented 6 months ago

Something is broken with the Nav Items, they look funky: image

joebochill commented 6 months ago

Suggest you take a look at this and consider enabling the react-hooks eslint plugin to help catch all of the missing dependency array entries: https://github.com/etn-ccis/blui-react-component-library/issues/860