etn-ccis / blui-react-component-library

Re-usable React components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
16 stars 10 forks source link

appbar out of sync check animating is finished #858

Closed JeffGreiner-eaton closed 5 months ago

JeffGreiner-eaton commented 6 months ago

Fixes https://github.com/etn-ccis/blui-react-component-library/issues/736.

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

-

To Test:

Any specific feedback you are looking for?

-

codecov[bot] commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f47f62b) 84.03% compared to head (cd31838) 83.93%.

Files Patch % Lines
components/src/core/AppBar/AppBar.tsx 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #858 +/- ## ========================================== - Coverage 84.03% 83.93% -0.10% ========================================== Files 58 58 Lines 1234 1239 +5 Branches 158 159 +1 ========================================== + Hits 1037 1040 +3 - Misses 98 100 +2 Partials 99 99 ``` | [Flag](https://app.codecov.io/gh/etn-ccis/blui-react-component-library/pull/858/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/etn-ccis/blui-react-component-library/pull/858/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | `83.93% <60.00%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

Visit the preview URL for this PR (updated for commit cd31838):

https://blui-react-docs--pr858-bug-blui-5306-sync-a-xoung6dm.web.app

(expires Sat, 24 Feb 2024 18:33:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

JeffGreiner-eaton commented 6 months ago

I'll need to add some additional testing to appbar