search

etn-ccis / blui-react-component-library

Re-usable React components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
16 stars 10 forks source link

Incorrect prop type in Toolbar Menu #871

Open surajeaton opened 4 months ago

surajeaton commented 4 months ago

Describe the bug / expected behavior

Incorrect items prop type in Toolbar Menu Groups Object

What are the steps to reproduce?

  1. Go to...
  2. Scroll down to Toolbar Menu Groups Object
  3. The items prop has incorrect type and no link to the reference

Screenshots / Screen recording

Screenshot 2024-04-10 at 4 52 11 PM

Code snippet / Link to minimum reproduction example

CODE HERE

Your environment information

Suggested fix

Update the type to ToolbarMenuCompItem and add a link to https://github.com/etn-ccis/blui-react-component-library/blob/2fb920025a3bbe424c1892b502de7ebbffad702d/components/src/core/ToolbarMenu/ToolbarMenu.tsx#L34

Anything else to add?

huayunh commented 4 months ago

So why is "tool bar menu object" still listed in this screenshot? Why do we go with a vague name like ToolbarMenuCompItem?

image

ektaghag-eaton commented 4 months ago

Leave ToolbarMenuCompItem as it is and new ToolbarMenuItem like export type ToolbarMenuItem = ToolbarMenuCompItem

We should use the type ToolbarMenuItem in our code.