etn-ccis / blui-react-component-library

Re-usable React components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
17 stars 10 forks source link

Feature/6187 update component css variables #922

Open surajeaton opened 1 week ago

surajeaton commented 1 week ago

Fixes # BLUI-6187 BLUI-6186

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

-

To Test:

Any specific feedback you are looking for?

-

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (54a3e9c) to head (21b2acf). Report is 4 commits behind head on release/mui-v6.

Files with missing lines Patch % Lines
.../src/core/Drawer/DrawerRailItem/DrawerRailItem.tsx 71.42% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/mui-v6 #922 +/- ## =============================================== Coverage 80.85% 80.85% =============================================== Files 47 47 Lines 1238 1238 Branches 156 156 =============================================== Hits 1001 1001 Misses 136 136 Partials 101 101 ``` | [Flag](https://app.codecov.io/gh/etn-ccis/blui-react-component-library/pull/922/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/etn-ccis/blui-react-component-library/pull/922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | `80.85% <89.47%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JeffGreiner-eaton commented 1 week ago

We are not running any checks for this branch. We should temporally set blui-ci to run for this branch. try updating to this and see if it works

image image image
ektaghag-eaton commented 6 days ago

Getting below errors while running docs.

Screenshot 2024-11-08 at 3 38 32 PM

@surajeaton , can you please update test instructions ?

surajeaton commented 6 days ago

Getting below errors while running docs. Screenshot 2024-11-08 at 3 38 32 PM

@surajeaton , can you please update test instructions ?

Looks like I will have to update the showcase as well to test. Let's hold off on this PR for now.

surajeaton commented 3 days ago

We are not running any checks for this branch. We should temporally set blui-ci to run for this branch. try updating to this and see if it works

image image image

@JeffGreiner-eaton Added. Please review