search

etn-ccis / blui-react-native-component-library

Re-usable React-Native components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
11 stars 8 forks source link

EmptyState prop `description` has different type than in react component #546

Closed surajeaton closed 6 months ago

surajeaton commented 6 months ago

Describe the bug / expected behavior

EmptyState prop description has different type than in react component

What are the steps to reproduce?

  1. Check https://github.com/etn-ccis/blui-react-component-library/blob/b6dae00bda5bb14071a0cada2a699509a36d205c/components/src/core/EmptyState/EmptyState.tsx#L29
  2. Check https://github.com/etn-ccis/blui-react-native-component-library/blob/2b8c80055f5dae99c9575f20057a5f287633469b/components/src/core/EmptyState/EmptyState.tsx#L48
  3. The description prop has ReactNode type in react comp library and string in react native comp library

Screenshots / Screen recording

Code snippet / Link to minimum reproduction example

CODE HERE

Your environment information

Found while using EmptyState in https://github.com/etn-ccis/blui-react-native-workflows/blob/release/R31/login-workflow/src/screens/SuccessScreen/SuccessScreenBase.tsx

Suggested fix

We may need to update react native comp library's EmptyState description prop type to ReactNode

Anything else to add?