etn-ccis / blui-react-native-component-library

Re-usable React-Native components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
11 stars 8 forks source link

remove deprecated defaultprops #590

Closed ArshdeepSingh3-eaton closed 4 months ago

ArshdeepSingh3-eaton commented 4 months ago

Fixes # . removed use of defaultProps

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

-

To Test:

Any specific feedback you are looking for?

-

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.45%. Comparing base (e9f07f3) to head (f150ab3). Report is 5 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #590 +/- ## ========================================== - Coverage 70.52% 70.45% -0.08% ========================================== Files 67 67 Lines 1245 1242 -3 Branches 185 185 ========================================== - Hits 878 875 -3 Misses 340 340 Partials 27 27 ``` | [Flag](https://app.codecov.io/gh/etn-ccis/blui-react-native-component-library/pull/590/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/etn-ccis/blui-react-native-component-library/pull/590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | `70.45% <100.00%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jeffvg commented 4 months ago

is this for bug https://github.com/etn-ccis/blui-react-native-component-library/issues/576 also do we need a change log entry for this

ArshdeepSingh3-eaton commented 4 months ago

we don't need to add changelog entry as nothing has changed and it's just a enhancement just a method update on how to pass default props

manojleaton commented 4 months ago

Looks good