etn-ccis / blui-react-native-component-library

Re-usable React-Native components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
11 stars 8 forks source link

Fix additional bugs on RN components #596

Closed manojleaton closed 3 months ago

manojleaton commented 4 months ago

Fixes #BLUI-5839 .

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

-

To Test:

Any specific feedback you are looking for?

-

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.39%. Comparing base (2e03883) to head (2562fff).

Files Patch % Lines
components/src/core/Drawer/Drawer.tsx 0.00% 2 Missing :warning:
components/src/core/Drawer/DrawerNavItem.tsx 0.00% 2 Missing :warning:
components/src/core/Drawer/DrawerNavGroup.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #596 +/- ## ========================================== - Coverage 70.62% 70.39% -0.23% ========================================== Files 67 67 Lines 1239 1243 +4 Branches 183 183 ========================================== Hits 875 875 - Misses 337 341 +4 Partials 27 27 ``` | [Flag](https://app.codecov.io/gh/etn-ccis/blui-react-native-component-library/pull/596/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/etn-ccis/blui-react-native-component-library/pull/596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | `70.39% <0.00%> (-0.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ektaghag-eaton commented 4 months ago

https://github.com/etn-ccis/blui-react-native-component-library/issues/578 will be fixed here