search

etn-ccis / blui-react-native-component-library

Re-usable React-Native components for use in Brightlayer UI applications
BSD 3-Clause "New" or "Revised" License
11 stars 8 forks source link

Update auto complete prop names #614

Open JeffGreiner-eaton opened 3 weeks ago

JeffGreiner-eaton commented 3 weeks ago

Describe the bug / expected behavior

Capitalization of the allowCustomtag prop — should be allowCustomTag. Rename the limitCharacterCountTag prop to tagCharacterLimit.

What are the steps to reproduce?

  1. Go to https://github.com/etn-ccis/blui-react-native-component-library/blob/dev/components/src/core/AutoComplete/AutoComplete.tsx#L62
  2. and https://github.com/etn-ccis/blui-react-native-component-library/blob/dev/components/src/core/AutoComplete/AutoComplete.tsx#L44

Screenshots / Screen recording

Code snippet / Link to minimum reproduction example

CODE HERE

Your environment information

Suggested fix

Anything else to add?

shubham-eaton commented 2 weeks ago

Prop name change is a breaking change, hence we need to add it into a major change or we could leave the old props as alias in the minor version.