etn-ccis / blui-react-native-workflows

Re-usable Brightlayer UI workflows for React Native applications
6 stars 6 forks source link

Image background is visible in real mobile device #421

Closed ArshdeepSingh3-eaton closed 1 month ago

ArshdeepSingh3-eaton commented 1 month ago

Fixes # . updated Height to fix Image background is visible in real mobile device

Changes proposed in this Pull Request:

-

-

Screenshots / Screen Recording (if applicable)

-

To Test:

-

Any specific feedback you are looking for?

-

ektaghag-eaton commented 1 month ago

Can you add screenshot of real device?

joebochill commented 1 month ago

Does this change affect the ability to rotate the device and have the display update/adapt appropriately?

ArshdeepSingh3-eaton commented 1 month ago

it does not affect the rotate capability MicrosoftTeams-image (3)

MicrosoftTeams-image (2)

JeffGreiner-eaton commented 1 month ago

seems ok on iOS simulator

image

android 😏 emulator was never really good at this stuff

https://github.com/etn-ccis/blui-react-native-workflows/assets/119693939/c442c681-0bd1-498f-b533-64e3d5364df0

image
JeffGreiner-eaton commented 1 month ago

I looked at this again and I don't know what to think about the landscape view on android and I don't really trust the emulator.

https://github.com/etn-ccis/blui-react-native-workflows/assets/119693939/e7dc3097-d8c9-4d73-9c85-5eaf61606717

JeffGreiner-eaton commented 1 month ago

https://github.com/etn-ccis/blui-react-native-workflows/assets/119693939/6f945aea-f83b-4fba-9ebd-8fc477c9595b

JeffGreiner-eaton commented 1 month ago

The EULA screen seems to re-render or refresh and switches back to portrait slightly better than the create account screen. But still don't trust this one bit on emulator

https://github.com/etn-ccis/blui-react-native-workflows/assets/119693939/74667ec5-6a5d-450c-8a11-bd92ae4acf48

ArshdeepSingh3-eaton commented 1 month ago

on real device i can see that screen for a second and then it changes into correct ui

JeffGreiner-eaton commented 1 month ago

on real device i can see that screen for a second and then it changes into correct ui

sounds good, can you rebase or fix the conflict here on workflow card