Feat/5537 fix example app

etn-ccis / blui-react-native-workflows

Re-usable Brightlayer UI workflows for React Native applications

6 stars 6 forks source link

Feat/5537 fix example app #431

Closed ektaghag-eaton closed 2 weeks ago

ektaghag-eaton commented 1 month ago

Changes proposed in this Pull Request:

[X] application loads user is not authenticated by default
[X] Use Login base screen is displayed, which should have
[X] a mock Login button which simply toggles the user authenticated status
[X] a dummy link to reset password
[X] a dummy link to Register which loads the registration workflow route
[X] Click the dummy link to ResetPassword / Forgot password / Contact support loads respective screen
[X] Closing the reset password screen pops it off the navigation stack and we should be back at the dummy login screen.

Screenshots / Screen Recording (if applicable)

- simulator_screenshot_40ADAAB2-D99E-433B-BAAE-96DF5FCF9F26

To Test:

Any specific feedback you are looking for?

JeffGreiner-eaton commented 1 month ago

looks good. You can update home.tsx to uppercase Home.tsx and update drawer for correct active item. (if you are viewing dashboard page the locations is active in drawer and same for locations in view and dashboard active.

Do we know why all the nav.navigate and navigation.navigate in the screens/components in example all seem to not like the string values for login, home, destination, openDrawer.....

ektaghag-eaton commented 1 month ago

looks good. You can update home.tsx to uppercase Home.tsx and update drawer for correct active item. (if you are viewing dashboard page the locations is active in drawer and same for locations in view and dashboard active.

Do we know why all the nav.navigate and navigation.navigate in the screens/components in example all seem to not like the string values for login, home, destination, openDrawer.....

Hi @JeffGreiner-eaton, let me check. Need to update the routing setup again, making this PR a draft.

JeffGreiner-eaton commented 3 weeks ago

Navigation looks good to other screens/workflows but the create account needs adjusted

JeffGreiner-eaton commented 2 weeks ago

Theme, languages, screens, workflow..etc all look really good. Is this just typescript complaining on types or do we need to add items to the stack?

JeffGreiner-eaton commented 2 weeks ago

I did notice when we toggle RTL>LTR we loose our remember me data. I don't think this is an issue considering we rerender the app and the refresh drops the data.

JeffGreiner-eaton commented 2 weeks ago

Looks like the app isn't finding device language. Changing device language to anything other than english and reloading app/installing displays login screen in english. Do we have everything from here https://github.com/etn-ccis/blui-react-native-workflows/pull/438

JeffGreiner-eaton commented 2 weeks ago

One last item, user menu should be translated

joebochill commented 2 weeks ago

We need to prioritize getting this done and merged ASAP — the smoke test story should ideally be testing the application after it has been set up correctly, otherwise we are. going to have to go back and check it again. Let's get the routing pieces finalized and working — translations are a minor detail that can be covered in a follow-up PR. But we absolutely must get the structure finished as soon as we can.

ArshdeepSingh3-eaton commented 2 weeks ago

fix the linting error

JeffGreiner-eaton commented 2 weeks ago

Changing to RTL and selecting change password from user menu throws error

Changing to RTL and selecting logout throws error

Remember me not working now

ektaghag-eaton commented 2 weeks ago

Closing this PR, and open new PR https://github.com/etn-ccis/blui-react-native-workflows/pull/457