etn-ccis / blui-react-native-workflows

Re-usable Brightlayer UI workflows for React Native applications
6 stars 6 forks source link

Workflow is unusable with soft keyboard #447

Closed manojleaton closed 2 weeks ago

manojleaton commented 3 weeks ago

Fixes #BLUI-5536 .

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

Screenshot 2024-04-17 at 1 42 58 PM

To Test:

-

Any specific feedback you are looking for?

-

JeffGreiner-eaton commented 3 weeks ago

is there a way to keep the input field visible and not get pushed up under header?

image image image
JeffGreiner-eaton commented 3 weeks ago

On android I'm not able to see input fields

image image
ArshdeepSingh3-eaton commented 3 weeks ago

@JeffGreiner-eaton we have locked the orientation to portrait so Landscape orientation is not possible

JeffGreiner-eaton commented 2 weeks ago

@JeffGreiner-eaton we have locked the orientation to portrait so Landscape orientation is not possible

I'm confused why we would do this. We had the refactor of workflow card work here - https://github.com/etn-ccis/blui-react-native-workflows/pull/334

If landscape only works on tablet and not phones we need to document this @joebochill

JeffGreiner-eaton commented 2 weeks ago

@JeffGreiner-eaton we have locked the orientation to portrait so Landscape orientation is not possible

I'm confused why we would do this. We had the refactor of workflow card work here - #334

If landscape only works on tablet and not phones we need to document this @joebochill

ok I miss understood layout for phone devices. We should add documentation on this and let our adopters know that landscape will not work on phone devices and document the "how to configure the application/routing to enforce that"

manojleaton commented 2 weeks ago

@JeffGreiner-eaton we have locked the orientation to portrait so Landscape orientation is not possible

I'm confused why we would do this. We had the refactor of workflow card work here - #334

If landscape only works on tablet and not phones we need to document this @joebochill

It is already documented by @ArshdeepSingh3-eaton, please check routing.md Had a discussion with @joebochill and he suggested to create a bug for this issue 450.