Convert Hero Component to live code examples

etn-ccis / blui-react-native

This monorepo includes all the Brightlayer UI's react native resources

1 stars 2 forks source link

Convert Hero Component to live code examples #57

Closed priyankakmEaton closed 3 months ago

priyankakmEaton commented 3 months ago

Fixes #5795

Changes proposed in this Pull Request:

-Convert images to live RN code (using react-native-web)

-Remove unused image assets

-Convert markdown code blocks to PrismJS code blocks

-Use PrismJS to highlight targeted lines in the code example blocks

-Include buttons to copy to clipboard and view full github source

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

ArshdeepSingh3-eaton commented 3 months ago

we haven't added that example because the icon prop has a type definition for IconSource and we have icon component to showcase variants in which it can be used SVG is not supported and i don't think we can use png for icon component

ektaghag-eaton commented 3 months ago

Hi @priyankakmEaton , did you fix all the above comments? Is it ready for review again?

priyankakmEaton commented 3 months ago

Yes @ektaghag-eaton , I have made changes

ektaghag-eaton commented 3 months ago

Yes @ektaghag-eaton , I have made changes

JeffGreiner-eaton commented 3 months ago

This looks good with updates. Should we just use icon={{ family: 'brightlayer-ui', name: 'fan' }}

JeffGreiner-eaton commented 3 months ago

The first example is using HeroBanner with only one hero it should have 2 or more hero