etn-ccis / blui-react-themes

Brightlayer UI themes for Eaton applications
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Dialog cards gets too bright in dark theme #82

Open huayunh opened 1 year ago

huayunh commented 1 year ago

Describe the bug / expected behavior

This is originally discovered at https://github.com/etn-ccis/blui-react-workflows/issues/418. In the dark theme, they added an extra "elevation" layer to push the card away from the darker background. Unfortunately this made the card extra bright.

This might be no longer necessary when MD3 rolls out. But for the current version, it just feels strange.

What are the steps to reproduce?

  1. Go to react auth workflow example project
  2. Login.
  3. Open the change password card / dialog box

Screenshots / Screen recording

Current state:

image

I expect:

image
ektaghag-eaton commented 1 year ago

We won't fix this before the MD3 update.