SX Style overrides do not work on full screens

manojleaton commented 3 months ago

Fixes #BLUI-5975 .

Changes proposed in this Pull Request:

Fix for the issue

Screenshots / Screen Recording (if applicable)

-

To Test:

Pass styles to any of the full screen components and verify
Example: sx={{ backgroundColor: 'orange', '& .MuiCardContent-root':{ backgroundColor: 'red', '::-webkit-scrollbar': { width: 0 } } }}

Any specific feedback you are looking for?

-

JeffGreiner-eaton commented 3 months ago

the example doesn't run unless you pass placeholder={undefined} onPointerEnterCapture={undefined} onPointerLeaveCapture={undefined} for Drawer, DrawerNavGroup, DrawerBody...etc in exampleHome component

ektaghag-eaton commented 3 months ago

the example doesn't run unless you pass placeholder={undefined} onPointerEnterCapture={undefined} onPointerLeaveCapture={undefined} for Drawer, DrawerNavGroup, DrawerBody...etc in exampleHome component

This issue might be because of https://github.com/etn-ccis/blui-react-workflows/commit/77c1e27bb169daec576bf9861d36644b72243d50. @manojleaton can you try to revert and test on local?

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit cdeead7):

https://blui-react-login--pr619-bug-5975-fix-react-w-4607isu9.web.app

_{(expires Sat, 10 Aug 2024 11:15:10 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043}

JeffGreiner-eaton commented 3 months ago

I was looking at the unit tests and if I run yarn test we have tests failing around the workflowcards and props but if I run each test individually the tests pass, weird. Also notice some tests failing on login, okta and several others. I'm not sure whats been updated to cause this but some tests having issues.

ektaghag-eaton commented 3 months ago

I was looking at the unit tests and if I run yarn test we have tests failing around the workflowcards and props but if I run each test individually the tests pass, weird. Also notice some tests failing on login, okta and several others. I'm not sure whats been updated to cause this but some tests having issues.

Might be because of this commit https://github.com/etn-ccis/blui-react-workflows/pull/619/commits/fabda4b7fcfcf602c32ff2037d868c6275c5e578. will check with Manoj and Update PR.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.76%. Comparing base (26048c4) to head (cdeead7).

Files	Patch %	Lines
...ns/ResetPasswordScreen/ResetPasswordScreenBase.tsx	0.00%	0 Missing and 1 partial :warning:
...ow/src/screens/SuccessScreen/SuccessScreenBase.tsx	0.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #619 +/- ## ========================================== - Coverage 73.58% 72.76% -0.82% ========================================== Files 86 86 Lines 1098 1098 Branches 243 243 ========================================== - Hits 808 799 -9 - Misses 115 122 +7 - Partials 175 177 +2 ``` | [Flag](https://app.codecov.io/gh/etn-ccis/blui-react-workflows/pull/619/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/etn-ccis/blui-react-workflows/pull/619/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis) | `72.76% <33.33%> (-0.82%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=etn-ccis#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

etn-ccis / blui-react-workflows