Closed d-a-bunin closed 10 months ago
In #178 it was found that tbats models fail on data with integer timestamp. It could be fixed.
Fix tests tests/test_models/test_inference/test_forecast/TestForecastOutSample for models:
tests/test_models/test_inference/test_forecast/TestForecastOutSample
BATSModel
TBATSModel
Error:
ValueError: Model is not fitted! Fit the model before calling predict method!
The problem is with _TBATSAdapter.forecast which checks if self._freq is None which is now a valid value.
_TBATSAdapter.forecast
if self._freq is None
self._freq
tests/test_models/test_inference/test_predict/TestPredictInSampleSuffix
Blocked by #178.
Closed by #195.
🚀 Feature Request
In #178 it was found that tbats models fail on data with integer timestamp. It could be fixed.
Proposal
Fix tests
tests/test_models/test_inference/test_forecast/TestForecastOutSample
for models:BATSModel
TBATSModel
Error:
The problem is with
_TBATSAdapter.forecast
which checksif self._freq is None
which is now a valid value.self._freq
should be changed.Test cases
tests/test_models/test_inference/test_forecast/TestForecastOutSample
from fail to success categorytests/test_models/test_inference/test_predict/TestPredictInSampleSuffix
from fail to success categoryAdditional context
Blocked by #178.