etna-team / etna

ETNA – Time-Series Library
https://docs.etna.ai
Apache License 2.0
140 stars 7 forks source link

Update `BATSModel`, `TBATSModel` to handle integer timestamp #181

Closed d-a-bunin closed 10 months ago

d-a-bunin commented 11 months ago

🚀 Feature Request

In #178 it was found that tbats models fail on data with integer timestamp. It could be fixed.

Proposal

Fix tests tests/test_models/test_inference/test_forecast/TestForecastOutSample for models:

Error:

ValueError: Model is not fitted! Fit the model before calling predict method!

The problem is with _TBATSAdapter.forecast which checks if self._freq is None which is now a valid value.

Test cases

Additional context

Blocked by #178.

d-a-bunin commented 10 months ago

Closed by #195.