search

etnetera / owasp-dependency-check

MIT License
6 stars 13 forks source link

Update utils.js to fix version issue with patch part of it #24

Closed Rishabh-dipsite closed 4 months ago

Rishabh-dipsite commented 6 months ago

There is an issue when running osap-dependecy-check, the assets name in res.json releases the release version digits has more than 1 digit for patch part, so we need to adapt the regex for checking release

image

image

image

vincego commented 6 months ago

@Rishabh-dipsite your regexp will work fine for a while, but will break at next major version 10.x.x, you might want to use regexp as proposed in the issue \d+\.\d+\.\d+ which allows any number of digits for each part

Rishabh-dipsite commented 6 months ago

@Rishabh-dipsite your regexp will work fine for a while, but will break at next major version 10.x.x, you might want to use regexp as proposed in the issue \d+\.\d+\.\d+ which allows any number of digits for each part

Adapted, thanks 😅

Rishabh-dipsite commented 6 months ago

@centi / @etnetera-admin , Please someone take a look and merge. I want to use this package on latest release and this issue is blocking me. Many thanks

vincego commented 6 months ago

@centi / @etnetera-admin , Please someone take a look and merge. I want to use this package on latest release and this issue is blocking me. Many thanks

In the meantime you might want to depend on this PR adapting your package.json : "owasp-dependency-check": "etnetera/owasp-dependency-check#pull/24/head"

OmarKasbah commented 6 months ago

Please somebody have a look at the PR :`(

martin-traverse commented 6 months ago

As well as merging the PR, is it possible to get a version pushed to NPM? Linking CI to GitHub for compliance checks feels a bit dodgy to me...

Rishabh-dipsite commented 6 months ago

@centi , Please merge these changes, these are minor fix and will be very helpful for all the users. Let me know if I should include changes for version change in package.json or anything else you would need.

centi commented 4 months ago

@Rishabh-dipsite Please review and update your PR after I accepted the previous PR which also suggested a change in the regexp. Then I'll merge it + publish a release.

Rishabh-dipsite commented 4 months ago

@Rishabh-dipsite Please review and update your PR after I accepted the previous PR which also suggested a change in the regexp. Then I'll merge it + publish a release.

Created a new PR #25. Please take a look at it, thanks 🙂