search

eto-ai / rikai

Parquet-based ML data format optimized for working with unstructured data
https://rikai.readthedocs.io/en/latest/
Apache License 2.0
136 stars 19 forks source link

Pin scenedetect < 0.6 #570

Closed Breakthrough closed 2 years ago

Breakthrough commented 2 years ago

Hi there! I'm the author of PySceneDetect (scenedetect package), and noticed that you haven't pinned the dependency. The next release (v0.6) is slated to include some breaking changes to improve the API usage, so I would recommend that you pin your version to scenedetect < 0.6, otherwise the current source code will break once that is released.

For how your project uses the library in subtitld/modules/file_io.py, it would be just one-line function in the new version (example). The new version will also be multithreaded so will run much faster. Thank you!

changhiskhan commented 2 years ago

Thanks @Breakthrough for the heads-up. When's the next release for pyscenedetect going to come out?

Breakthrough commented 2 years ago

There's a beta out now, so if all goes smoothly should have the new release out by the end of this month.

Also one last thing to note, the default threshold was changed from 30 down to 27 as per issue Breakthrough/PyScenedetect#246. I noticed you had stored that same value, so you may also want to lower it to be slightly more sensitive. This isn't required though, and do note that it would cause behavioural differences.

Thanks!