search

eto-ai / rikai

Parquet-based ML data format optimized for working with unstructured data
https://rikai.readthedocs.io/en/latest/
Apache License 2.0
136 stars 19 forks source link

add mixin ComposableDrawable #602

Closed Renkai closed 2 years ago

Renkai commented 2 years ago

related issue: https://github.com/eto-ai/rikai/issues/550

da-liii commented 2 years ago

The main issue I have is that the abstractions seem really confusing.

I think so. I think the only interface introduced here is Box2d + "label_text". (abstractions for impl purpose should be re-impl-ed later) The impl abstractions are not ideal, but it works. That's why I approved this pull request.

Renkai commented 2 years ago

Replaced by a simplified version here https://github.com/eto-ai/rikai/pull/632