search

eto-ai / rikai

Parquet-based ML data format optimized for working with unstructured data
https://rikai.readthedocs.io/en/latest/
Apache License 2.0
136 stars 19 forks source link

Can we bump the version of `antlr4-python3-runtime`? #706

Closed dnnspark closed 1 year ago

dnnspark commented 1 year ago

Hello!

Just asking: is there a reason that the version of antlr4-python3-runtime is pinned to 4.8 (https://github.com/eto-ai/rikai/blob/main/python/setup.py#L69)? I have seen multiple times that this conflicts with other libraries. Current stable version of that library is 4.11.1. I believe upgrading to at least 4.9 would help a lot.

changhiskhan commented 1 year ago

Yeah we can definitely update the version. It's pinned mainly so we don't get surprise breakage when antlr updates. Can definitely take a look.

changhiskhan commented 1 year ago

If you don't mind, what are you mainly using Rikai for? Any other feature you're really hoping to get or bugs that need to be fixed?

dnnspark commented 1 year ago

Hi @changhiskhan ! Thanks for the prompt response, and your willingness to upgrade that library! To answer your question, we use rikai for providing SQL extensions for inference of model-based data mining. I don't interactive with this part a lot; it's part of the bigger codebase I use. If I work more closely with rikai in the future, I will definitely post my feedback again.

changhiskhan commented 1 year ago

@dnnspark please see #707 for the PR to upgrade to 4.11.1 does this solve your issue? If so we'll look to make a bugfix release this week or next.

dnnspark commented 1 year ago

@changhiskhan Yes! This solves my issue. Thank you very much! Looking forward to the next release.

changhiskhan commented 1 year ago

hi @dnnspark we made a new release with the changes you requested. Lmk if everything still works as you expected. If it's easier, happy to continue over email to discuss in more detail (chang@eto.ai)