etoa / etoa-gui

EtoA Game GUI
https://etoa.ch
GNU Affero General Public License v3.0
10 stars 7 forks source link

WIP: Migrated ranking class #363

Closed mrcage closed 3 years ago

mrcage commented 3 years ago

dbquery still needs to be refactored

mrcage commented 3 years ago

No merge yet, its a work in progess

glaubinix commented 3 years ago

@mrcage is there anything still missing here? Not sure whether this is ok to review/merge as the title still says WIP

mrcage commented 3 years ago

There are still some dbquery calls left, but unfortunately i am currently not finding the time to work on these.... can you have a look, or merge it and we do the remaining queries later?

mrcage commented 3 years ago

The current state of the branch is fine, everything should work, its just not complete in terms of dbquery migration

glaubinix commented 3 years ago

Yeah, that's fine. I'll go ahead and merge this for now. Will avoid further merge conflicts and either of us can pick this up once we get there.