etoa / etoa-gui

EtoA Game GUI
https://etoa.ch
GNU Affero General Public License v3.0
10 stars 7 forks source link

White page after planet is deleted #554

Open yaench opened 1 year ago

yaench commented 1 year ago

If a user deletes a planet, the page is completely white. In the Admin-Tool, a database failure is reported:

30.10.2022 16:34:42, 2a02:1210:3676:7500:99ef:14a7:e2e4:253c, SeriousOffender
Database error

File: /var/www/etoa/htdocs/classes/dbmanager.class.php, line: 176

Query:

            SELECT
                l.shiplist_ship_id as lid,
                l.shiplist_count as lcnt,
                l.shiplist_bunkered as lbcnt,
                l.shiplist_special_ship_bonus_weapon as bweapon,
                l.shiplist_special_ship_bonus_structure as bstructure,
                l.shiplist_special_ship_bonus_shield as bshield,
        l.shiplist_special_ship_bonus_heal as bheal,
                s.*
            FROM
                shiplist l
            INNER JOIN
                ships s 
            ON
                s.ship_id = l.shiplist_ship_id
                AND l.shiplist_user_id=47
                AND l.shiplist_entity_id=
                AND l.shiplist_count>0
            ;

Error Message:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND l.shiplist_count>0' at line 18

Stack-Trace:

#0 /var/www/etoa/htdocs/inc/functions.inc.php(50): DBManager->query('\n\t\t\tSELECT\n\t\t\t\t...', 1)
#1 /var/www/etoa/htdocs/classes/shiplist.class.php(43): dbquery('\n\t\t\tSELECT\n\t\t\t\t...')
#2 /var/www/etoa/htdocs/classes/shiplist.class.php(18): ShipList->load()
#3 /var/www/etoa/htdocs/content/planetoverview.php(205): ShipList->__construct(NULL, '47', 1)
#4 /var/www/etoa/htdocs/inc/content.inc.php(241): include('/var/www/etoa/h...')
#5 /var/www/etoa/htdocs/index.php(298): require('/var/www/etoa/h...')
#6 {main}

The user has to re-open the page. When I tried to reload the page, the browser asked me for confirmation, I agreed, and then, EtoA told me, that I cannot remove my main planet. I had only the main planet left, I don't know if that would have deleted another planet?