ion-google-place cannot work with ng-cordova-oauth

chicheongweng commented 8 years ago

I can confirm ion-google-place project works fine on iPhone until I add ng-cordova-oauth. ion-google-place and ng-cordova-oauth work fine independently.

As soon as I add the following line to www/index.html, I am getting google.maps undefined error. Any idea why?

Here is my complete index.html

<!DOCTYPE html>

``` ```

chicheongweng commented 8 years ago

Narrowed down the index.html to as follows. The ion-google-place directive only works if I remove the line lib/ng-cordova-oauth/dist/ng-cordova-oauth.min.js Otherwise I will get error Error: undefined is not an object (evaluating 'new google.maps.Geocoder')

<!DOCTYPE html>

``` ```

pdfowler commented 8 years ago

This problem appears to be much wider than just how ion-google-place works, since the ngCordovaOauth overrides the $window.google variable, which is the standard variable used for any number of google based services.

Although this may not solve your problem (eg: you are using google+ OAuth), I've worked around it as follows:

Change your script imports to the following:

    <!--<script src="lib/ng-cordova-oauth/lib/ng-cordova-oauth.js"></script>-->
    <!-- 
        Disable import of full OAuth Library b/c it overwrites the `window.google` variable used for google maps.
        Instead, just import the OAuth Utilities file, along with the OAuth Providers that you require
    -->
    <script src="lib/ng-cordova-oauth/src/utility.js"></script>
    <script src="lib/ng-cordova-oauth/src/oauth.facebook.js"></script>

When initializing your app, import only the specific OAuth providers you need, not ngCordovaOauth as a whole:

    angular.module('myapp', ['oauth.facebook']);

Figured I'd share this here while I look for a related issue in the ngCordovaOauth project

Edison767e commented 8 years ago

@fatty1380 Thanks for sharing! we had similar problem with ngCordovaOauth

etodanik / ion-google-place

ion-google-place cannot work with ng-cordova-oauth #63