search

etodanik / ion-google-place

Ionic directive for a location dropdown that utilizes google maps
MIT License
250 stars 201 forks source link

use autocomplete service instead of geocoder service #78

Open Freundschaft opened 8 years ago

Freundschaft commented 8 years ago

I have replaced the gecoder service with the autocomplete service, which results in much better autocompletion suggestions. The only downside to this is that you need to add a second request that resolves the autocomplete place to a latlng

Find the changes here: https://github.com/gfnork/ion-google-place/commit/6814f78029b5a02d25191a785b809ca1ea0d4b92#diff-ec24f7d4c28e05471405031c8f3947b8R252

jakeywan commented 8 years ago

Where's the uiGmapgoogle-maps module you're injecting? I gave this a whirl and it failed to instantiate because it's missing.

Freundschaft commented 8 years ago

sorry, its from http://angular-ui.github.io/angular-google-maps/ but you dont have to use it, its only for loading the google maps api and to make sure its there, you can also lazy load it or use any other method to load it.

mohamed-ahmed commented 8 years ago

Whats the 'Card' service you're using. Seems pretty proprietary.

Freundschaft commented 8 years ago

ah shit, forget about the card service, its some code from our own project that shows a custom infobox to the user, just remove Card and all references to it, it will still work, or replace it with ionicmodal