etodanik / ion-google-place

Ionic directive for a location dropdown that utilizes google maps
MIT License
251 stars 201 forks source link

Does it work with ionic 1.3.2 on Android? #97

Open jakub-g opened 7 years ago

jakub-g commented 7 years ago

Hi, I tested the version in master on Android 5 inside ionic 1.3.2 app (angular 1.5.3) and there are a number of things that are plainly not working or really bizarre:

Since this repo has 245 stars, I believe this should be a reasonable plugin, and either I'm doing something wrong, or the code is no longer well behaving with newer ionic/angular?

arjunbanker commented 7 years ago

i also recently discovered this plugin and am noticing similar behavior w/ ionic 1.3.2 ios+android

jakub-g commented 7 years ago

@arjunbanker FYI finally I forked https://github.com/ivanthecrazy/ion-place-autocomplete and did some small changes on top of that - the code is very small and very easy to extend to add some custom requirements to the behavior of the autocomplete

(I added an additional call to Google via their Places library to get details about the selection, and some other small changes, but I didn't opensource it yet)

etodanik commented 7 years ago

@jakub-g the polite thing in the open source world would be to contribute back upstream from your fork :)

jakub-g commented 7 years ago

@israelidanny I will, once I finish the dev and the code is stable enough :)

tobeee commented 7 years ago

Hey @jakub-g - did you manage to open source the rest of your additions? Would love to see how they work =)

anjali14garg commented 7 years ago

Why Behaviour is changed for ios and android. In ios it is working fine but why not in android. Please suggest some solution for it