Fix linter issues - Githubissues

etolbakov / excalidocker-rs

Convert your docker-compose into excalidraw

MIT License

123 stars 6 forks source link

Fix linter issues #13

Closed etolbakov closed 1 year ago

etolbakov commented 1 year ago

The code is in relatively untidy state. Commands

cargo check --all-features
cargo fmt -- --check
cargo clippy -- -D warnings

produce a lot of actions (unused code, not optimal methods etc). This needs to be addressed.

[x] clippy issues
[x] cargo check
[x] format issues

etolbakov commented 1 year ago

Partially addressed in https://github.com/etolbakov/excalidocker-rs/pull/23

etolbakov commented 1 year ago

Fully addressed here https://github.com/etolbakov/excalidocker-rs/pull/32 Declared #[allow(clippy::too_many_arguments)] for some functions as it's by-design. Potentially, could be addressed later at some point.