search

etorreborre / specs2

Software Specifications for Scala
http://specs2.org
Other
733 stars 215 forks source link

Add `NoAutoHtmlLinkFragments` trait disabling stringToHtmlLinkFragments(2) #220

Closed sirthias closed 10 years ago

sirthias commented 10 years ago

Currently the

implicit def stringToHtmlLinkFragments(s: String): HtmlLinkFragments
implicit def stringToHtmlLinkFragments2(s: String): HtmlLinkFragments2

implicits collide with application-level pimps of ~ onto Strings. In spray we therefore added NoAutoHtmlLinkFragments trait (in analogy to the NoTimeConversions mixin that is already available with specs2): https://github.com/spray/spray/blob/c826c2c7015ed4e044885b1edd793ae4907688db/spray-testkit/src/main/scala/spray/testkit/Specs2Interface.scala#L33

Now we discovered that we need the same thing again for parboiled2. It'd be great if specs2 could incorporate this trait directly.

sirthias commented 10 years ago

Thanks, Eric!

etorreborre commented 10 years ago

This is published as 2.3.6 btw

sirthias commented 10 years ago

Nice, thanks!

sirthias commented 10 years ago

Eric, there appears to be a problem with the 2.3.6 publishing: http://oss.sonatype.org/content/repositories/releases/org/specs2/specs2-core_2.10/2.3.6/ is missing the actual artifacts!

etorreborre commented 10 years ago

Sorry about the publishing. First time Sonatype does this. I might have to re- publish as 2.3.7 :-(

sirthias commented 10 years ago

No worries at all. Thanks for being so responsive!

etorreborre commented 10 years ago

This should be fixed now.

sirthias commented 10 years ago

Yes, I can confirm the fix. Thank you!

FranklinChen commented 9 years ago

What happened to this features in 3.6?

etorreborre commented 9 years ago

@FranklinChen sorry I missed that. I've now re-introduced some traits for deactivating the DSL operations. You can now use org.specs2.specification.dsl.NoReferenceDsl in 3.6-20150530005327-c890398.