etotheipi / BitcoinArmory

Python-Based Bitcoin Software
Other
826 stars 618 forks source link

SatoshiDatadir setting is ignored when doAutoBitcoind is false #288

Open gurnec opened 9 years ago

gurnec commented 9 years ago

ArmoryMainWindow.__init__() calls either startBitcoindIfNecessary() or loadBlockchainIfNecessary() here.

startBitcoindIfNecessary() calls setSatoshiPaths() here, which configures the SatoshiDatadir.

loadBlockchainIfNecessary() does not call setSatoshiPaths(), which leaves SatoshiDatadir set as its default, even if it's been configured by the user to a custom location via the config file.

This seems like a bug to me. I'm not sure if the correct solution is to move the setSatoshiPaths() call out of startBitcoindIfNecessary() and into ArmoryMainWindow.__init__() (before either startBitcoindIfNecessary() or loadBlockchainIfNecessary() is called), or to add a call to setSatoshiPaths() inside loadBlockchainIfNecessary(), or something else entirely.